Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue-522 #638

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fix: issue-522 #638

merged 2 commits into from
Jun 12, 2024

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Jun 11, 2024

Questions Answers
Description? Fix #522
Type? bug fix / improvement
BC breaks? no
Deprecations?
Fixed ticket? Fix #522
Sponsor company @PrestaShopCorp
How to test? ⬇️

This PR introduces a new feature where a closable alert appears when a product is removed from the cart. This alert contains a link to the deleted product, allowing users to navigate back to the product page in case the deletion was unintended.

Steps to Reproduce

  1. Add several products to the cart.
  2. Go to the cart page.
  3. Click on the remove button for a product.
  4. New: A closable alert appears with a link to the deleted product, allowing users to go back to the product page in case of an accidental deletion.

Video:

cart_remove_alert.mov

ga-devfront
ga-devfront previously approved these changes Jun 11, 2024
boherm
boherm previously approved these changes Jun 11, 2024
@tblivet tblivet dismissed stale reviews from boherm and ga-devfront via ff7ea90 June 12, 2024 09:04
@ps-jarvis
Copy link

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

  • Shop.Theme.Checkout
    • Remove
  • Shop.Theme.Actions
    • has been removed from the cart.

(Note: this is an automated message, but answering it will reach a real human)

Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

Works as expected.

Tested deleting the product from Remove button and from Quantity button. The alert is displayed as it should. After Refreshing the page, the alert is removed. The link to product is correct. Tested re-adding the product after deleting it. All is good.

It is QA ✅
Thanks!

@tblivet tblivet merged commit 824f925 into PrestaShop:develop Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a success banner when user delete an article to his cart
5 participants